Dotzu icon indicating copy to clipboard operation
Dotzu copied to clipboard
verified publisher icon remirobert

Feature/make bubble head optional

Open k-thorat opened this issue 8 years ago • 4 comments

In this PR, I have added option to use Dotzu without Bubble Head and configure LogSettings programmatically.

Why?

  • We are using Dotzu with some in-house debugging tools. We were looking to manage all the debugging tools at one place.

Summary of changes:

  • Made LogSettings public and added var to track show/hide bubble head
  • Made Manager window & controller optional
  • Opened access to ManagerViewController from DotzuManager
  • Updated example with LogSettings

Notes:

  • Why Bubble head setting is not added to Dotzu Settings? ** I am working on another PR, which adds more options to LogSettings and it may get cumbersome to maintain.

Thanks a lot for your time.

Cheers!

k-thorat avatar Oct 08 '17 03:10 k-thorat

You have the same PR twice. Can you correct that before merging? LGTM 💯

remirobert avatar Oct 11 '17 19:10 remirobert

Oops! I was working on two features and didn't switch branch :(

PR 44 has all my changes. Lets chat on PR 44.

k-thorat avatar Oct 12 '17 11:10 k-thorat

I think, I know why. PR 43 & 44 are connected. 44 is built on top of 43. That's why 44 showing same commits of 43. So, you can accept just 43 and not 44.

If you prefer to work on one PR in this case then I will close PR 43.

Please let me know if this makes sense.

k-thorat avatar Oct 12 '17 11:10 k-thorat

@liman123 That's great. I am sure this is awesome tool. I have already got 4 messages from you. so please stop spamming my inbox.

k-thorat avatar Jan 11 '18 02:01 k-thorat