Dotzu icon indicating copy to clipboard operation
Dotzu copied to clipboard

Decouple NSKeyArchiver from StoreManager.swift

Open johndpope opened this issue 8 years ago • 3 comments

further to investigation https://github.com/remirobert/Dotzu-Objective-c/issues/4

I drafted this code for your review https://gist.github.com/johndpope/1dd3663a8712bb1901536a44bccd6a5a

this way - if we can get this into core library, I can over ride this with any library that conforms to logging protocol,

protocol LogProvider { func archiveLogs(logs: [T]) func storedDataForKey(key:String)->NSData? func logs() -> [T] func reset() }

johndpope avatar May 11 '17 15:05 johndpope

when my app starts - there's so much rapid logging - it takes dotzu logger some time to catch up. need to fix this. If I open a PR - will you consider merging?

johndpope avatar Jun 01 '17 19:06 johndpope

@remirobert - fyi https://github.com/gregheo/SwiftAveiro2017

johndpope avatar Jun 09 '17 17:06 johndpope

@remirobert - this library is conflicting with another library that is unhooking the following hooks.

-> LoggerCrash.unregister() this is called - even though - register is never called. NSSetUncaughtExceptionHandler(nil) signal(SIGILL, SIG_DFL) signal(SIGABRT, SIG_DFL) signal(SIGFPE, SIG_DFL) signal(SIGBUS, SIG_DFL) signal(SIGSEGV, SIG_DFL) signal(SIGSYS, SIG_DFL) signal(SIGPIPE, SIG_DFL) signal(SIGTRAP, SIG_DFL)

wwe-johndpope avatar Jul 07 '17 23:07 wwe-johndpope