Adding a domain to an app doesn't have any effect until you deploy again

[ejholmes]

Not a huge deal, but might be nice if it did the needful when you add the domain.

[rgabo]

@ejholmes thanks for putting this issue up, saved a few cycles of troubleshooting. What has thrown me off was that a simple emp deploy remind101/acme-inc:latest will deploy and create an internal LB at which point if you domain-add and try to deploy, it will error out with error: currently assigned load balancer is not suitable for the given exposure.

This issue helped realize that you can create first (similar to Dokku which we also use) and set up config/env and only then deploy. Works as expected now and this is probably just a documentation issue which I realize is very early for :wink:

Awesome project btw, we're already running a dev cluster. We were going to do vanilla ECS then empire just hit :smile:

[zachlatta]

Thanks for putting this up as well, was pretty confused as well. We also have a dev cluster up and are probably going to switch some (not very important) services over to Empire in production soon. Thanks so much!

[phobologic]

Adding this here, in case other people are curious - if you want to have an externally exposed application, say 'remind101/acme-inc:latest', you should do the following:

emp create acme-inc
emp domain-add -a acme-inc acme-inc.example.com
emp deploy remind101/acme-inc:latest

Unfortunately moving from internal to external services is a little difficult, especially without downtime, and we don't have a solution to it yet (that's what this issue is about :))