Rémi

Cause of the problem: `TopologyGenerators.generateRing()` had incoherent positioning and dimensioning values. Fix: A new method, which centers the shape in the `Topology` and sizes it to secure a margin. Bonus:...

@acasteigts , please have a look at branch `fix/111-topologygenerators-generateRing-positioning`. Note: It is not based on `develop`, but on the branch which fixes #108 .

merged into `develop`.

@acasteigts, as you mentioned in another thread, `TopologyGenerators.generateRing()` uses the proper model. The "issue" comes from the fact that the `RingGenerator`, as any child of `AbstractGenerator`, separately stores a _nodeClass_...

This being said, `AbstractGenerator` could be notified rather easily, to try and get the `Topology`'s default node model if none has been set using `AbstractGenerator.setNodeClass()`.

I suppose we could postpone the decision on this issue. Moreover, the following "workaround" should work: ``` RingGenerator generator = new RingGenerator(nbNodes); [...] generator.setNodeClass(RedNode.class); generator.generate(topology); ``` What do you think?

I have made a proposition on branch `fix/110-ringgenerator-default-node`. I will try and create a PR, for practice purpose.

Looks good to me. Ready to be shipped in next release. Rmq: I don't think this new piece of code is used anywhere in the production/test/example code of the project....

rebased over `develop`.

ok for me. You can merge it into `develop`. We'll make a nicer history next time :)