her icon indicating copy to clipboard operation
her copied to clipboard

Fix infinite loop when parsing nested associations

Open gordysc opened this issue 4 years ago • 1 comments

It appears with this commit a potential infinite loop was introduced if models defined both has_many/belongs_to.

To mitigate this, I've added a straightforward check for belongs_to to no-op if the association is already defined on the resulting object. Also, sorry for the previous PR! Moved this under my company's organization for easy access to the rest of my team.

Finally, it appears we're now respecting included_root_element for nested associations. This PR also adds an option to opt out of this new behavior as well as potentially use a different name via included_embedded_root_element

gordysc avatar Sep 10 '20 20:09 gordysc

Somebody please give a medal to this man! (and merge this PR :stuck_out_tongue: )

gabrielrdrguez avatar Sep 15 '21 21:09 gabrielrdrguez