headphones icon indicating copy to clipboard operation
headphones copied to clipboard

Python 3.12 support - headphones does not run because of deprecated ImpImporter

Open jason1987d opened this issue 1 year ago • 3 comments

Upon launching /opt/headphones/Headphones.py with a system python 3.12. It is my understanding 3.12 removed ImpImporter.

raceback (most recent call last):
  File "/opt/headphones/Headphones.py", line 27, in <module>
    from headphones import webstart, logger
  File "/opt/headphones/headphones/__init__.py", line 27, in <module>
    import cherrypy
  File "/opt/headphones/lib/cherrypy/__init__.py", line 60, in <module>
    import pkg_resources
  File "/opt/headphones/lib/pkg_resources/__init__.py", line 2172, in <module>
    register_finder(pkgutil.ImpImporter, find_on_path)
                    ^^^^^^^^^^^^^^^^^^^
AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?

jason1987d avatar Dec 10 '23 02:12 jason1987d

Having the same problem, headphones won't run with python3.12. Please fix.

ottoking8912 avatar Dec 19 '23 11:12 ottoking8912

Hey, would you guys mind trying out the python312 branch? If that's too tricky I can get it into develop, but I think there are just too many changes to get it into master right now. Sorry also for the delay

rembo10 avatar Jan 18 '24 10:01 rembo10

Hey, would you guys mind trying out the python312 branch? If that's too tricky I can get it into develop, but I think there are just too many changes to get it into master right now. Sorry also for the delay

Yes, I ran from this branch and it runs on linux with python 3.12 installation. Selecting multiple albums or the 'all' checkbox from an artist for 'Wanted' appears to not work 'You didn't select any albums', not sure if there's already an issue for this. Still testing other features.

jason1987d avatar Jan 18 '24 17:01 jason1987d

Hey, would you guys mind trying out the python312 branch? If that's too tricky I can get it into develop, but I think there are just too many changes to get it into master right now. Sorry also for the delay

Any news on getting this fix into main?

uniquePWD avatar May 24 '24 06:05 uniquePWD

It's there now.... I'll cut a release...

rembo10 avatar May 26 '24 04:05 rembo10