relrelb

Results 17 comments of relrelb

> Welome! I think `instant::Instant` can be used in place of the proposed `RuffleDuration`. `instant` is already a dependency of `ruffle-core`, and currently being used in various places across the...

Actually, `ruffle-core` already has a [`deterministic`](https://github.com/ruffle-rs/ruffle/blob/8efd69b5255ea1c0f0cdd2a87f01ff1c9077bf35/core/Cargo.toml#L72) feature exactly for this purpose, which is enabled by `exporter`. It is currently used for mocking time/date, so I suggest to simply use [`get_current_date_time()`](https://github.com/ruffle-rs/ruffle/blob/8efd69b5255ea1c0f0cdd2a87f01ff1c9077bf35/core/src/locale.rs#L8)...

Wouldn't it be easier to store the viewport in `Stage` (or even better IMO, `Player`) instead? This way we won't need to duplicate the same code in each of the...

> I'll be honest, I have absolutely no idea how to interact with Mixer stuff. Meanwhile, the "stage sound transform" is something I can totally grok :) And having it...

From my understanding, BMP images are represented in an SWF as `DefineBits` tags, which are supported in Ruffle. Can you please report what exactly is not supported? Referring to an...

Regarding the sound issue - the SWF uses Nellymoser compression (#5).

AS3 is still a work in progress, please refer to #1368.

> @relrelb Did you wanna close this? No, I re-opened this issue intentionally because the fix commit was flawed and was reverted in #5471, so this issue remains.

> This basically reverts [57ccb71](https://github.com/ruffle-rs/ruffle/commit/57ccb714c606904af49ee9c715bc6182d442be94), which was part of #5021. > How come this is now only relevant for AVM1? We already have `ruffle_render::color_transform::ColorTransform` (and the equivalent `swf::ColorTransform`) as common...

Going to merge this in order to unblock future PRs that build upon it.