Gravity
Gravity copied to clipboard
Rsapi Unit tests are not properly using VerifyAll
Our provider tests are supposed to call mockProvider.VerifyAll
after every test. But the code to do so is decorated with a SetUp
attribute instead of a TearDown
attribute, which never fires. Here is an example:
https://github.com/relativitydev/Gravity/blob/a4874bcd88a50f126070396d72c4dc336461c5e3/Gravity/Gravity.Test.Unit/RsapiDaoInsertTests.cs#L41-L46
Flipping this value shows that 10 tests are not written to meet the verification criterion:
In the process of fixing this, we should create a base unit test class to handle the mockProvider
setup and verification.