continuous-eval icon indicating copy to clipboard operation
continuous-eval copied to clipboard

[Ellipsis] Enhance SQL Syntax Matching with AST Comparison

Open ellipsis-dev[bot] opened this issue 1 month ago • 0 comments

This change addresses review comments left by @yisz on PR #59: Add SQL Metrics Implementation

:warning: We couldn't build/test your project to verify our changes. Add a Dockerfile to significantly improve code quality.

Summary:

Enhanced the SQLSyntaxMatch metric in continuous_eval/metrics/code/sql/sql_deterministic_metrics.py by replacing string comparison with AST comparison for more accurate SQL query evaluation.

Key points:

  • Updated SQLSyntaxMatch in continuous_eval/metrics/code/sql/sql_deterministic_metrics.py.
  • Replaced string comparison with AST comparison in __call__ method.
  • Added compare_ast method for AST comparison (placeholder implementation).

You can configure Ellipsis to address comments with a direct commit or a side PR, see docs.


Something look wrong?: If this Pull Request doesn't address the comments left on the above pull request, create a new PR review with more details. For more information, check the documentation.

Generated with :heart: by ellipsis.dev

ellipsis-dev[bot] avatar May 16 '24 20:05 ellipsis-dev[bot]