hotstuff icon indicating copy to clipboard operation
hotstuff copied to clipboard

Removed leafBlock from synchronizer

Open leandernikolaus opened this issue 2 years ago • 1 comments

I wanted to study the semantics of the synchronizer, and I found that the leafBlock is always the block from the highQC. Therefore, in the current implementation, we could omit the leafBlock.

leandernikolaus avatar Sep 23 '22 06:09 leandernikolaus

I've looked at the code, and it looks fine to me. But could edit the PR description to provide some more context for this. Do you think we won't need the LeafBlock() for alternative synchronizer implementations?

meling avatar Sep 23 '22 11:09 meling

I don't see any issues with this PR.

@hanish520 Would this conflict with any of your other changes?

@johningve If you have a cycle to spare, please let us know your take.

I want to merge this if there are no concerns with this.

meling avatar Feb 11 '23 19:02 meling