gorums icon indicating copy to clipboard operation
gorums copied to clipboard

thinking: what to do when the NodeStream dies with an error?

Open meling opened this issue 11 months ago • 0 comments

See issue #212. This code snippet from server.go:NodeStream:

	for {
		req := newMessage(requestType)
		err := srv.RecvMsg(req)
		if err != nil {
			return err
		}

May return this error:

rpc error: code = Internal desc = grpc: failed to unmarshal the received message: proto: not found

However, the server-side never sees this message unless you hack into the Gorums dependency.

We should consider logging errors returned by the NodeStream call. Or some other solution... Need to think a bit more about it.

meling avatar Mar 06 '25 23:03 meling