SVGKit
SVGKit copied to clipboard
reklis
Transforms - mostly implemented
Massive MASSIVE changes here (150 files changed!)
Generating this pull request so you can see what's changed, see what you think...
Actually, you'd only need to wrap the bits you wanted to wrap. Obj-c and C++ can cohabitate in the same project or library very nicely, even if the memory management was a little screwy in older versions of the sdk. With the latest LLVM it's much nicer. A thin layer of Obj-C on a powerful open source C++ library like webcore could be very compelling indeed.
I tried merging the patch using git apply, and it failed with tons of rejections. I then tried applying the patch manually using patch -p1 which failed to completely apply as expected, but I then stepped through each rejection line by line and manually applied them. In the end, I couldn't make heads or tails of the pbxfile changes, so I rebuilt the project, specifically the ipad project manually by including the updated source files. That failed to compile for many reasons, I think most of which was some confusion about SVGDocument missing width and height. I then gave up on the patch and branched my own reklis:master to reklis:transforms killed Core, iOS and XCodeProjects and copied in adamgit:transforms wholesale.
Ignoring any attempt at merging, your branch does actually compile with a smattering of memory leak issues. Once I was able to actually build the project, any attempt to load any of the sample file svgs ended with this error: "Extra content at the end of the document".
Ignoring the code changes completely, without functional parsing even at a basic level, I simply cannot merge this patch. Perhaps you can test your branch some more, and we can try again.
Something deeply wrong there - i'm using the branch in live projects! No compile problems, no problems with the demo project, etc.
I've just updated to latest llvm and xcode, i'll check what happens with a full clean here.
Nb the "extra data at end of document" Iirc is a message from the 3rd party xml parser, and means you have a non legal xml file - usually you have some tags after the root tag, or you are missing the required namespace. I'll check that too - it might be that i switched to a different bersion of the libxml and sonehow failed to include it?
On Wednesday, 19 September 2012, Steven Fusco wrote:
I tried merging the patch using git apply, and it failed with tons of rejections. I then tried applying the patch manually using patch -p1 which failed to completely apply as expected, but I then stepped through each rejection line by line and manually applied them. In the end, I couldn't make heads or tails of the pbxfile changes, so I rebuilt the project, specifically the ipad project manually by including the updated source files. That failed to compile for many reasons, I think most of which was some confusion about SVGDocument missing width and height. I then gave up on the patch and branched my own reklis:master to reklis:transforms killed Core, iOS and XCodeProjects and copied in adamgit:transforms wholesale.
Ignoring any attempt at merging, your branch does actually compile with a smattering of memory leak issues. Once I was able to actually build the project, any attempt to load any of the sample file svgs ended with this error: "Extra content at the end of the document".
Ignoring the code changes completely, without functional parsing even at a basic level, I simply cannot merge this patch. Perhaps you can test your branch some more, and we can try again.
— Reply to this email directly or view it on GitHubhttps://github.com/reklis/SVGKit/pull/21#issuecomment-8678516.
I know you are using this code, so I figured it was probably some minor issue
It seems ive fixed it - committed
I think a git merge went wrong on my end so id uploaded a mess of code. Ive cleaned it up and rewritten some of the bits (i gave up untangling them - too many changes!)
Latest commit is loading all svgpad tests now - although the monkey looks slightly wrong to me
On Wednesday, 19 September 2012, Steven Fusco wrote:
I know you are using this code, so I figured it was probably some minor issue
— Reply to this email directly or view it on GitHubhttps://github.com/reklis/SVGKit/pull/21#issuecomment-8692585.