hfs icon indicating copy to clipboard operation
hfs copied to clipboard

Linking a descript.ion file for a virtual folder (home) doesn't work

Open jbrown123 opened this issue 1 year ago • 2 comments

BEFORE

  • Are you using a reverse-proxy, like nginx?

Not using, doesn't matter

To Reproduce Steps to reproduce the behavior: Create a link to an on-disk file named descript.ion in a virtual folder (I did it in home) Note that the file or folder doesn't have a comment in the web UI

Describe the bug The descript.ion file is not read / processed / used in a virtual folder

Expected behavior I expect the descript.ion file linked in the virtual folder to work just as it works in a real on-disk folder

Screenshots Not really applicable here

Environment (please complete the following information):

  • OS: Windows 10, 64 bit
  • HFS Version 0.52.9 (latest stable)
  • Browser chrome (doesn't matter)

Additional context Is there some other way, without making home (or other virtual folders) an on-disk folder, to get descriptions to work?

Can we just restore the (much better) comment functionality from the v2 HFS? image

jbrown123 avatar Jul 01 '24 01:07 jbrown123

so, what you are trying to do, is to have comments for items inside a virtual folder (like your home). While I see the sense in your attempt, I think it's better to have something similar to hfs2, with the comment that can be set from the VFS itself.

rejetto avatar Jul 01 '24 09:07 rejetto

Yes, please!

I'd MUCH prefer to have the comment functionality from v2 ported to v3!

That said, I still believe this is a bug since it doesn't operate consistently between virtual & physical folders.

jbrown123 avatar Jul 01 '24 15:07 jbrown123

this is ready for 0.54

rejetto avatar Jul 10 '24 14:07 rejetto

version 0.54.0-alpha1 is out and includes this

rejetto avatar Jul 20 '24 21:07 rejetto

Comments attached to links don't work. The comment is never displayed.

    - name: HFS - link to website
      url: https://www.rejetto.com/hfs/
      icon: link
      comment: Link to the HFS homepage

image

Here you can see that the comment worked for the local file (HFS - http file server (executable)) entry, but not for the link entry below that. image

jbrown123 avatar Jul 21 '24 22:07 jbrown123