rejeep
Create symlink for emacsclient in use! method.
I started to use evm in linux and the emacsclient binary is not present. The PR solves this.
@rejeep, I'm not totally convinced with this approach, If you have a better idea I will be happy to modify this PR. I'll add specs after receiving your feedback. Thanks!
ps: I'm not 100% sure, but emacsclient in mac osx is not working well, right?
If you have a better idea I will be happy to modify this PR.
Not sure. There are other binaries in the same directory as emacsclient that we also might want to add. Maybe the best solution is to add emacs and all binaries in the bin directory. What do you think?
ps: I'm not 100% sure, but emacsclient in mac osx is not working well, right?
I think it should work. I don't know, I don't use it myself, except that Magit uses it to commit.
Another solution is to link Evm's bin directory to the Emacs installation bin directory. And then also link emacs in that directory to the binary (not sure, but I think emacs is already in that directory on Linux, but it's not on OSX).
Evm's bin directory exists and it has the evm binary, then it isn't possible to link it to the Emacs installation bin directory.
I'll try to implement the first option, add emacs and all binaries in the bin directory. Could you show me what is the folder tree in OSX?
Evm's bin directory exists and it has the evm binary...
Ahh, right. Too bad, I liked that approach better. Try the first option and we'll so how it goes then.
Could you show me what is the folder tree in OSX?
Take a look here: https://github.com/rejeep/evm/blob/master/lib/evm/package.rb#L17-L23
Sorry, no. They are in /usr/local/evm/emacs-git-snapshot/Emacs.app/Contents/MacOS/bin
I updated the branch. Well, with this way, I think that something to clear the bin is needed because there are differents binaries between versions. ex:
$ ls /usr/local/evm/emacs-24.2-bin/bin/
ctags ebrowse emacs emacs-24.2 emacsclient etags grep-changelog rcs-checkin
$ ls /usr/local/evm/emacs-git-snapshot/bin/
ctags ebrowse emacs emacs-24.3.50 emacsclient etags grep-changelog
Another approach could be have a whitelist for binaries, and only symlink them. wdyt?
Besides this, there is something I don't understand: Why do you create the additional symlink evm-emacs ?
Another approach could be have a whitelist for binaries, and only symlink them. wdyt?
Sound good to me!
Why do you create the additional symlink evm-emacs ?
Because some people don't want the emacs binary to be an Evm Emacs version. These are mostly people that use Evm for testing. This way they can add the Evm path to the end of $PATH.
Also, could you add/update the specs please.
I'd also like to be able to use emacsclient via EVM. Is it intentional to link all binaries? Looks like the last update was to whitelist. @areina are you able to update this for the current code base or shall I open a new PR?
