revanced-builder icon indicating copy to clipboard operation
revanced-builder copied to clipboard

[Suggestion]: App versioning with patches

Open PalmDevs opened this issue 2 years ago • 2 comments

Builder should have something telling the user that a specific patch is available only in certain versions of the package. But it should also have support for building beta/unsupported versions of apps.

By adding --experimental in the patch command, this will make patches available to unsupported versions of the app. Patches may work or not work in this case.

There should be a checkbox to enable unsupported versions but it should be disabled by default.

About the package version selector, this should also include beta versions of a specific app instead of just stable versions. This again, should have a checkbox to show and hide these entries.

PalmDevs avatar Aug 05 '22 11:08 PalmDevs

This might be a good idea but I've never seen a patch being broken yet and also even if the actual patch works, ReVanced Team/Contributors has to update the supported version list for the patch. This suggestion might also confuse most of the users.

reisxd avatar Aug 05 '22 12:08 reisxd

Patch being broken will result in the CLI printing SERVERE: ..., but sometimes even if the patches succeeded, it would just be unusable on unsupported versions. So a just a warning modal that says

Unsupported patches This version does not support the patch-1, patch-2, and patch-3 patches. Would you like to continue anyway?

should be fine for me.


And about beta versions, just either no modal (because patches modal would show anyway) or the modal that says

Patches may fail Beta versions are usually unsupported and patches will either not work or just fail completely. Would you like to list beta versions anyway?

when enabling the option that shows the entries.

PalmDevs avatar Aug 05 '22 13:08 PalmDevs