Reinhold Füreder

Results 40 comments of Reinhold Füreder

Oh wow, today we extremely often get also **failures during downloading of plugins**! So maybe your comment in https://github.com/oleg-nenashev/demo-jenkins-config-as-code/commit/1c081dfead882c02c52185960a7408746cae4219#commitcomment-43409028 also applys for the downloading feature! ;-( **=> we have now...

Just a naive comment: * Could the fix be adding this getter (or should it be named `isAcceptMergeRequestOnSuccess()`) to `com.dabsquared.gitlabjenkins.GitLabPushTrigger`? ``` public boolean getAcceptMergeRequestOnSuccess() { return acceptMergeRequestOnSuccess; } ``` *...

Although I am in the context of a scripted pipeline I think I have a very similar desire/problem: * I need to override the default `com.lesfurets.jenkins.unit.BasePipelineTest.stringInterceptor` etc * https://github.com/reinholdfuereder/JenkinsPipelineUnit/tree/parameters *...

@nre-ableton and @sams-gleb This also links with https://github.com/jenkinsci/JenkinsPipelineUnit/pull/460 -- which I think is not the perfect way, because the logic in https://github.com/jenkinsci/JenkinsPipelineUnit/blob/e33365ad452dd181e7d275b45890167f78700f8e/src/main/groovy/com/lesfurets/jenkins/unit/BasePipelineTest.groovy#L28 is wrong with respect to `withCredentials([string(credentialsId: 'gitlab-api-token', variable:...

(Maybe related: https://github.com/jenkinsci/JenkinsPipelineUnit/pull/298#issuecomment-811802180?)

At first quick glance this looks really great! What do you (as the or one of the main contributor/s) think @nre-ableton?

@nre-ableton Sorry for my potentially "premature" comment, I have admittedly just started looking at jenkins pipeline (unit) testing and stumbled over this (interesting looking) PR... I actually hope/plan to really...

Would this also "help" for actual call stack output for `target` in `MethodCall`? E.g. based upon: https://github.com/kamilszymanski/jenkins-pipeline-automation-starter - For pipeline: ``` timestamps { node { stage('Generate data') { progressNotices.displayProgressNotice('Generating data')...

While this works fine in the Gradle build (on CLI), when opening this in IntelliJ (v2020.3.2 CE) I failed to get it working (for a very long time): - in...