semantic_logger icon indicating copy to clipboard operation
semantic_logger copied to clipboard

Fix Appenders#close referencing incorrect variable

Open vovimayhem opened this issue 1 year ago • 1 comments

Issue #291

Changelog

Pull requests will not be accepted without a description of this change under the [unreleased] section in the file CHANGELOG.

Description of changes

On 4.16.0, Appenders#close is referencing a non-existant variable appenders instead of closed_appenders, which looks it was left like that by mistake, causing errors when calling SemanticLogger#close_appenders!

This PR includes the fix proposed by @jesseyoungmann on Issue #291

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

vovimayhem avatar Aug 20 '24 16:08 vovimayhem

Alternative PR: #290

ixti avatar Aug 21 '24 05:08 ixti

This can be closed (via #290)

ixti avatar Sep 05 '24 14:09 ixti

Fixed with #290

reidmorrison avatar Sep 05 '24 23:09 reidmorrison