reidmorrison
Add honeybadger_events appender
Changelog
Entry added:
- Add appender for Honeybadger events/insights API
Description of changes
Adds an additional Honeybadger appender honeybadger_events for their events/insights API.
The appender uses the honeybadger gem and the Honeybadger.event method, which is intelligent about batching log lines and sending a single request.
I wonder if it would make sense to modify the existing appender instead of creating a new one. The non-exception branch of the log method could use Honeybadger.event to send the payload.
I considered that – it's a bit odd to use semantic_logger for exceptions when the honeybadger gem does it already. Unless I'm missing some clear benefit.
The problem IMO is that it's a change in behavior for anyone using it and would/should require a major release I would think.
This approach felt similar to the NewRelic vs NewRelicLogs appenders.
I considered that – it's a bit odd to use
semantic_loggerfor exceptions when the honeybadger gem does it already. Unless I'm missing some clear benefit.
Agreed :)
The problem IMO is that it's a change in behavior for anyone using it and would/should require a major release I would think.
This approach felt similar to the
NewRelicvsNewRelicLogsappenders.
Yeah, that makes sense.
Understandably we are calling it Honeybadger Events, since it uses the Event API, but they refer to overall solution as Honeybadger Insights: https://docs.honeybadger.io/guides/insights/
Can we rename the appender to HoneybadgerInsights ?
For anyone that first comes across the appender, Honeybadger Insights would be simpler to understand.
Understandably we are calling it Honeybadger Events, since it uses the Event API, but they refer to overall solution as Honeybadger Insights: https://docs.honeybadger.io/guides/insights/ Can we rename the appender to
HoneybadgerInsights?For anyone that first comes across the appender, Honeybadger Insights would be simpler to understand.
👍