rails_semantic_logger icon indicating copy to clipboard operation
rails_semantic_logger copied to clipboard

Fix checking of Rails version on ActiveRecord log subscriber

Open matko9 opened this issue 10 months ago • 1 comments
trafficstars

Issue

https://github.com/reidmorrison/rails_semantic_logger/issues/249

Description of changes

Don't check only for Rails 7, check for all version after also (Rails 8 and the future ones).

I see that on other parts of code you have conditions where you check if Rails version is bigger than 7 so I think this would be good to have for compatibility with new Rails versions. Of course, if there would be some needed changes in some Rails version in future, we would add new condition, but in case there is no need for that like now on Rails 8, we wouldn't have errors.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

matko9 avatar Jan 13 '25 11:01 matko9