Reid Morrison

Results 105 comments of Reid Morrison

Yes, that would be great, we have been running my fork for several months in production now. We first started on Rails 6.0 and are now running Rails 6.1. The...

Lol, good point, I have a `.rubocop.yml` file in the root path for all my open source projects. I need to add it to not only to this PR but...

@goodgravy I see you gave me merge privileges to this repo, do you want me to do a squash merge of the above commits? This gem can be significantly simplified...

Semantic Logger is as clean as I can make it, but Rails Semantic Logger is nothing but a huge ugly hack to try and get Rails to log in a...

Looking at the filter above, looks to me like you want to filter on the class name, not the message. ~~~ruby filter: Proc.new { |log| log.name != "Webhooks::GithubController" } ~~~...

These are the log tags we are running with Rails 6.1 and the correct hash log tags appear everywhere we see them: ~~~ruby config.log_tags = { request_id: :request_id, ip: :remote_ip,...

That is an invalid assumption on Sidekiq's part. Nothing we can do about it here. Unless you can get sidekick to use the public apis then you will need to...

Sorry, we don't use RSpec, you are on your own there.

I was hoping the community would contribute something generic for tests. In our application we have added a custom logger that gathers all log messages in memory for a specific...

I bet there are cleaner, better ways to build this into minitest and RSpec? The full log event structure that can be tested against: https://logger.rocketjob.io/log_struct.html This could be the start...