covid19-forecast-hub icon indicating copy to clipboard operation
covid19-forecast-hub copied to clipboard

Switch Zoltar upload action to use new validations code

Open ydhuang28 opened this issue 3 years ago • 1 comments

Issue

Currently, the Zoltar upload action uses old validations code. The action runs travis/upload_zoltar_master.sh, and in this shell script travis/validate-data.sh is run as a step. However, travis/validate-data.sh actually uses the validations code directly in code/validation/test_formatting.py, and not the corresponding new code.

Steps

  • [ ] Add covid19-forecast-hub-validations as a submodule in the hub
  • [ ] Modify Zoltar upload action
    • [ ] Add a step to explicitly clone the new validations submodule (regular git clone does not deep clone, i.e., recursively clone submodules)
    • [ ] Modify travis/validate-data.sh to use code in submodule
  • [ ] Test functionality

ydhuang28 avatar Aug 29 '21 02:08 ydhuang28

Per this Slack discussion, we are removing the misc_scripts directory. Attached are the three files in it, which may be useful for solving this issue.

misc_scripts.zip

matthewcornell avatar Jul 07 '22 13:07 matthewcornell