rehype icon indicating copy to clipboard operation
rehype copied to clipboard

Update plugins.md

Open mvogelgesang opened this issue 1 year ago • 3 comments

Adding rehype-table-data-label to the listing

Initial checklist

  • [x] I read the support docs
  • [x] I read the contributing guide
  • [x] I agree to follow the code of conduct
  • [x] I searched issues and couldn’t find anything (or linked relevant results below)
  • [-] If applicable, I’ve added docs and tests

Description of changes

Adding a link to a plugin I wrote to help turn markdown tables into more responsive HTML.

mvogelgesang avatar Jun 28 '24 13:06 mvogelgesang

Welcome @mvogelgesang! 👋 Thanks for sharing!

Some criteria to include packages in this list.

  • Some documentation with at least some instructions on how to use the package.
  • A CI job to run tests. (The tests are already there.)
  • A prepack script and CI job to build the types. (The JSDoc types are already there.)
  • The package should be published to npm.

source: https://github.com/syntax-tree/hast/pull/24#issuecomment-2015384111

Some more specific feedback:

  • data-label isn't standard and doesn't do anything, is this library intended to be used with a specific stylesheet or JavaScript library that does what you show in the screen capture?
  • What happens if there is a colspan? https://developer.mozilla.org/en-US/docs/Web/HTML/Element/td#colspan

ChristianMurphy avatar Jun 28 '24 14:06 ChristianMurphy

friendly ping @mvogelgesang did you see the question and comments?

ChristianMurphy avatar Jul 25 '24 16:07 ChristianMurphy

@ChristianMurphy 🤦 apologies, had lost track, will make updates and comment back here when it's in good shape (hopefully soon)

mvogelgesang avatar Jul 26 '24 00:07 mvogelgesang

Closing for now, feel free to reopen when you have some time, thanks!

wooorm avatar Sep 17 '24 10:09 wooorm

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

github-actions[bot] avatar Sep 17 '24 10:09 github-actions[bot]