react should be a peer dependency.

Open meesvandongen opened this issue 6 years ago • 5 comments

otherwise yarn will install react in "@rehooks/window-size/node_modules/react", which will break, as react 16.7.0 does not have hooks yet.

Jan 18 '19 14:01 meesvandongen

I'm going to copy-paste this hook because if I try to use it through npm it tries to use latest stable (which is incorrect).

Jan 30 '19 12:01 richard-uk1

Be sure to remove the react-dom devDependency as well then.

Jan 30 '19 12:01 meesvandongen

Be sure to remove the react-dom devDependency as well then.

I'm only copying index.js ;)

Jan 30 '19 12:01 richard-uk1

unable to use this hook until this is merged 😰

Jan 29 '20 15:01 callumacrae

Hey, now that we have React 17, this hook is importing a different version. Can this be merged?

Nov 05 '20 06:11 Goues