regolith-desktop icon indicating copy to clipboard operation
regolith-desktop copied to clipboard

Change rofication order to created_at desc

Open otavioschwanck opened this issue 3 years ago • 12 comments

make more sense to have the last notification on the top!

otavioschwanck avatar Sep 01 '21 17:09 otavioschwanck

yes i was looking into this to see if there was a way to change it in its configuration perhaps - if not i'll look for an alternative

gosirys avatar Sep 09 '21 06:09 gosirys

@farsil what are your thoughts here?

kgilmer avatar Sep 10 '21 03:09 kgilmer

I am not on regolith atm, but shouldn't the notifications be displayed in the order they are sent by the applications already?

farsil avatar Sep 10 '21 08:09 farsil

I am not on regolith atm, but shouldn't the notifications be displayed in the order they are sent by the applications already?

When i have more than 10+ notifications, i want to see from the latest to the oldest. I jus want to see the newer ones, example:

If i receive a notification from slack, i open the rofitication, i have to go all the way down to use the action of notification (that opens the conversation).

Would be more simplier to just open the rofication and press enter to focus the conversation

otavioschwanck avatar Sep 10 '21 20:09 otavioschwanck

Makes sense. I guess we need to reverse the list of notifications before displaying them.

farsil avatar Sep 11 '21 08:09 farsil

Well, ideally we could expose this as an Xresource setting so that users could override the default if they prefer a different sort order. I'm sorry my Python skills are all but forgotten. I looked over the various files @farsil but wasn't sure of the best place to enable a sort of the queue before being sent to the "gui client". If you could point me to where in the code you'd suggest and a rough idea of what functions I should use I can probably take care of the rest @farsil . Or, if you'd like to do it you're more than welcome :) TIA

kgilmer avatar Sep 11 '21 16:09 kgilmer

I would gladly do it myself, the problem is that right now I'm relocating and I have little time for side projects :( If you don't mind waiting a couple of weeks I can do it, otherwise you can add the resource in rofication/resources/_static.py and reverse the list at line 42 in _server.py if the resource is set.

farsil avatar Sep 28 '21 07:09 farsil

I have plenty of other fish to fry @farsil and will happily give you the time you need. Thank you!

kgilmer avatar Sep 29 '21 14:09 kgilmer

I created a the following PR https://github.com/regolith-linux/regolith-rofication/pull/18 to address this issue.

dferrand avatar Nov 24 '21 23:11 dferrand

I created a the following PR regolith-linux/regolith-rofication#18 to address this issue.

Would you consider adding sorting based on fields? Your PR works but it sorts by order or arrival (ascending or descending). I think it would be useful to expand this to support urgency, timestamp (or better, a combination of both).

cfsmp3 avatar Nov 24 '21 23:11 cfsmp3

It is now possible to sort on multiple fields. The default sort is by timestamp descending (newest messages first).

dferrand avatar Nov 25 '21 19:11 dferrand

UI has changed for Regolith in version 2. This feature is not implemented but will be tracked for the future.

kgilmer avatar May 13 '22 14:05 kgilmer