windows missing in ilia -p windows

[MHellmund]

Some applications, e.g. xterm, do not appear in the ilia -p windows list.

Reason: They do not set the _NET_WM_WINDOW_TYPE property. According to https://specifications.freedesktop.org/wm-spec/1.3/ar01s05.html, windows without this property should be taken by the WM as if _NET_WM_WINDOW_TYPE_NORMAL is set.

Please change the test in src/windows/WindowPage.vala:traverse_nodes() so that windows with window_type=="none" are included, too.

Thank you!

[kgilmer]

Hi @MHellmund , thanks for providing the background info and hints for implementation. That made it pretty easy to follow your thinking and make the change. I found that after allowing windows of type "unknown" to pass the filter that i3bar was also present. It doesn't make sense for i3bar to be in the window list. For now, I'm explicitly excluding it via it's class property. The change is building now into unstable, but I may opt to revert or change it if other issues pop up in testing.

[MHellmund]

Thank you! One could argue that this is a bug in i3bar. According to the specifications, only 'normal' windows like xterm are allowed to not set the window type. Apps like i3bar should set it to 'dock' or 'desktop', imho.

Perhaps the best solution for ilia would be some config mechanism, where users can include/exclude windows as they like according to class properties, similar to the i3 config?