Régis Behmo
Régis Behmo
Here's what I suggest: 1. Create a `CONFIG_LOADED` action in `tutor.hooks.catalog`. 2. This action should be called at the end of `tutor.config.load_full`. It should only be passed `deepcopy(config)`, and not...
Please do @CodeWithEmad :)
> we can either change where the action is called Yes, can we move it to `config.load`? > also, checking the MFE_HOST being a subdomain of LMS_HOST should occur here...
Sorry, moving to `config.load` was a terrible idea. Instead, I suggest the following; 1. Remove the line `config_full = tutor_config.load_full(context.root)`. This variable is only used with `--append`. 2. Modify the...
I think that OEP-45 makes sense for the most part, but I disagree with some of it. More specifically, defining settings in YAML files: I'm just not sure what we...
I always say that there are only two things that are difficult about Open edX: one is static assets, and the other is settings. While I think it's great that...
> How about we just modify the OEP to accept more formats for the config file? My suggestion is that OEP-45 should completely ignore the format of the config file....
To clarify my thought above, here's what I have in mind: ``` @hooks.Filters.IS_FILE_RENDERED.add() def _do_not_render_binary_files(result: bool, path: str) -> bool: if result and is_binary(path): result = False return result def...
Closed by the following commits: https://github.com/overhangio/tutor/commit/bb137c16d6bb3f8a60c6859a51663b4234fdda1a https://github.com/overhangio/tutor/commit/4a6896d8920518488a591a357a14b3ae0346ed1c Thanks for your contribution!
This feature should be even easier now that pluggable "do" tasks are part of Tutor.