react-native-webview-leaflet icon indicating copy to clipboard operation
react-native-webview-leaflet copied to clipboard

OwnPositionMarker property example README

Open GaetanKarst opened this issue 4 years ago • 1 comments
trafficstars

Hello,

While working with the library I have noted a small typo on the example for the OwnPositionMarker property on the readme.

The duration type is a number? and in the example it is declared as a string. A simple removal of the double quotes will fix it. Also there should be ':' after lng of the coords property.

Should I create a PR to be checked and merged for the aforementioned issue?

ownPositionMarker={{
    id: '1',
    coords: {lat: 36.00, lng, -76.00},
    icon: "❤️",
    size: [24, 24],
    animation: {
      name: AnimationType.BOUNCE,
      duration: ".5",
      delay: 0,
      interationCount: INFINITE_ANIMATION_ITERATIONS
    }
  }}

GaetanKarst avatar Jul 05 '21 16:07 GaetanKarst

The name property should also be named type as name doesn't exist in the MapMarkerAnimation interface.

GaetanKarst avatar Jul 06 '21 15:07 GaetanKarst