regen-ledger icon indicating copy to clipboard operation
regen-ledger copied to clipboard

refactor(x/ecocredit): update market params API

Open technicallyty opened this issue 2 years ago • 1 comments

Description

  • updates the marketplace params proto definitions

Closes: n/a


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

  • [ ] included the correct type prefix in the PR title
  • [ ] added ! to the type prefix if API or client breaking change
  • [ ] targeted the correct branch (see PR Targeting)
  • [ ] provided a link to the relevant issue or specification
  • [ ] followed the guidelines for building modules
  • [ ] included the necessary unit and integration tests
  • [ ] added a changelog entry to CHANGELOG.md
  • [ ] included comments for documenting Go code
  • [ ] updated the relevant documentation or specification
  • [ ] reviewed "Files changed" and left comments if necessary
  • [ ] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • [ ] confirmed the correct type prefix in the PR title
  • [ ] confirmed ! in the type prefix if API or client breaking change
  • [ ] confirmed all author checklist items have been addressed
  • [ ] reviewed state machine logic
  • [ ] reviewed API design and naming
  • [ ] reviewed documentation is accurate
  • [ ] reviewed tests and test coverage
  • [ ] manually tested (if applicable)

technicallyty avatar Mar 30 '22 23:03 technicallyty

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d0977e6). Click here to learn what that means. The diff coverage is 28.57%.

@@            Coverage Diff            @@
##             master     #963   +/-   ##
=========================================
  Coverage          ?   72.99%           
=========================================
  Files             ?      196           
  Lines             ?    23365           
  Branches          ?        0           
=========================================
  Hits              ?    17055           
  Misses            ?     4996           
  Partials          ?     1314           
Flag Coverage Δ
experimental-codecov 72.87% <28.57%> (?)
stable-codecov 67.89% <28.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Mar 31 '22 00:03 codecov[bot]

Closing per #1342 and #1346

ryanchristo avatar Aug 15 '22 22:08 ryanchristo