regen-ledger icon indicating copy to clipboard operation
regen-ledger copied to clipboard

feat(x/data)!: add configuration options

Open ryanchristo opened this issue 2 years ago • 1 comments

Description

This pull request adds configuration options for the data module to support custom IRI prefixes and multiple IRI versions.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

  • [ ] included the correct type prefix in the PR title
  • [ ] added ! to the type prefix if API or client breaking change
  • [ ] targeted the correct branch (see PR Targeting)
  • [ ] provided a link to the relevant issue or specification
  • [ ] followed the guidelines for building modules
  • [ ] included the necessary unit and integration tests
  • [ ] added a changelog entry to CHANGELOG.md
  • [ ] included comments for documenting Go code
  • [ ] updated the relevant documentation or specification
  • [ ] reviewed "Files changed" and left comments if necessary
  • [ ] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • [ ] confirmed the correct type prefix in the PR title
  • [ ] confirmed ! in the type prefix if API or client breaking change
  • [ ] confirmed all author checklist items have been addressed
  • [ ] reviewed state machine logic
  • [ ] reviewed API design and naming
  • [ ] reviewed documentation is accurate
  • [ ] reviewed tests and test coverage
  • [ ] manually tested (if applicable)

ryanchristo avatar Dec 16 '22 20:12 ryanchristo

Codecov Report

Merging #1699 (d7c5e56) into main (f0858cb) will increase coverage by 0.01%. The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
+ Coverage   72.81%   72.82%   +0.01%     
==========================================
  Files         228      228              
  Lines       13608    13614       +6     
==========================================
+ Hits         9909     9915       +6     
  Misses       2967     2967              
  Partials      732      732              
Impacted Files Coverage Δ
app/app.go 92.76% <100.00%> (+0.08%) :arrow_up:
x/data/client/testsuite/util.go 100.00% <100.00%> (ø)
x/data/server/msg_anchor.go 58.46% <100.00%> (ø)
x/data/server/query_anchor_by_hash.go 86.95% <100.00%> (ø)
x/data/server/query_anchor_by_iri.go 86.95% <100.00%> (ø)
x/data/server/query_attestations_by_hash.go 73.33% <100.00%> (ø)
x/data/server/query_attestations_by_iri.go 73.33% <100.00%> (ø)
x/data/server/query_convert_hash_to_iri.go 100.00% <100.00%> (ø)
x/data/server/query_resolvers_by_hash.go 68.75% <100.00%> (ø)

codecov[bot] avatar Dec 16 '22 20:12 codecov[bot]