regen-ledger icon indicating copy to clipboard operation
regen-ledger copied to clipboard

Published 20 hours ago • verified publisher icon regen-network

feat(app)!: add v4.1 upgrade handler

Open aleem1314 opened this issue 3 years ago • 1 comments

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

  • [ ] included the correct type prefix in the PR title
  • [ ] added ! to the type prefix if API or client breaking change
  • [ ] targeted the correct branch (see PR Targeting)
  • [ ] provided a link to the relevant issue or specification
  • [ ] followed the guidelines for building modules
  • [ ] included the necessary unit and integration tests
  • [ ] added a changelog entry to CHANGELOG.md
  • [ ] included comments for documenting Go code
  • [ ] updated the relevant documentation or specification
  • [ ] reviewed "Files changed" and left comments if necessary
  • [ ] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • [ ] confirmed the correct type prefix in the PR title
  • [ ] confirmed ! in the type prefix if API or client breaking change
  • [ ] confirmed all author checklist items have been addressed
  • [ ] reviewed state machine logic
  • [ ] reviewed API design and naming
  • [ ] reviewed documentation is accurate
  • [ ] reviewed tests and test coverage
  • [ ] manually tested (if applicable)

aleem1314 avatar Sep 21 '22 05:09 aleem1314

:warning: The sha of the head commit of this PR conflicts with #1494. Mergify cannot evaluate rules on this PR. :warning:

mergify[bot] avatar Sep 21 '22 05:09 mergify[bot]

@kaustubhkapatral did you test the latest updates from this pr?

anilcse avatar Sep 28 '22 16:09 anilcse

@anilCSE we're hoping to have an RC tagged today so @kaustubhkapatral can to a final round of tests against that.

clevinson avatar Sep 28 '22 16:09 clevinson

utACK. checked the SDK and they handle valset resets similarly.

can you point to code in the SDK that does valset resets @technicallyty ?

aaronc avatar Sep 28 '22 19:09 aaronc

utACK. checked the SDK and they handle valset resets similarly.

can you point to code in the SDK that does valset resets @technicallyty ?

err maybe not valset resets but single validator resets, my bad 🤦🏻

was looking here https://github.com/cosmos/cosmos-sdk/blob/main/x/slashing/keeper/infractions.go#L103-L105 and https://github.com/cosmos/cosmos-sdk/blob/3d0e214446fbd888621da5a5f87ed90ce87d17ef/x/slashing/keeper/signing_info.go#L151-L158

technicallyty avatar Sep 28 '22 21:09 technicallyty