supporting-python-3 icon indicating copy to clipboard operation
supporting-python-3 copied to clipboard

Published 20 hours ago • verified publisher icon regebro

Fix name of "six.moves.StringIO".

Open ericvsmith opened this issue 5 years ago • 4 comments

The correct name is StringIO, not CStringIO.

ericvsmith avatar Apr 10 '19 12:04 ericvsmith

I don't think this one character change needs a CLA.

ericvsmith avatar Apr 10 '19 12:04 ericvsmith

Thanks for this!

I was surprised about this, and checked. And in fact, both works. The documentation only mentions cStringIO, though, which is strange. And there of course is just six.StringIO, which has the benefit of dealing with both bytes and unicode, so that should also be mentioned, really.

I need to add a few more words about this, I think.

regebro avatar Apr 10 '19 17:04 regebro

I was surprised, too.

And looking back through my command history, it's because I typo'd "cStringIO" as "CStringIO". I'm an idiot. Sorry for the noise. I would have sworn I copy and pasted that text from the web page, but I guess I didn't.

I apologize for wasting your time.

ericvsmith avatar Apr 10 '19 18:04 ericvsmith

Nono, all good, this clearly needs updating, even if it isn't a bug. I'll leave it open as a reminder.

regebro avatar Apr 10 '19 19:04 regebro