github-actions-dhall icon indicating copy to clipboard operation
github-actions-dhall copied to clipboard

continue-on-error type should be `Optional <Bool | Text>`?

Open zeeshanlakhani opened this issue 3 years ago • 3 comments

There are instances where you'd like the continue-on-error field in a job to reference a matrix variable for example that can itself be true or false. However, with the current type being Optional Bool, there's no way to take-in a \${{matrix.blah}} Text/String.

I thought about adding a PR, but wanted to throw up an issue first and get your thoughts.

zeeshanlakhani avatar Jun 10 '21 14:06 zeeshanlakhani

Hi @zeeshanlakhani sorry for the late reply! Lately time has been scarse!

I can see the use case and it's usefulness; Not sure if you still want to give a go! I would love to see your take on it!

regadas avatar Jun 26 '21 16:06 regadas

@regadas no worries at all. Yeah, I'm in the midst of a paper deadline, but maybe if I get some time in between or after for sure. I've already been talking to @joedevivo about it as we start using more dhall for our CI generation at work :).

zeeshanlakhani avatar Jun 26 '21 16:06 zeeshanlakhani

The same goes for cancel-in-progress in Concurrency, for example:

concurrency:
  group: ${{ github.ref }}
  cancel-in-progress: ${{ github.event_name == 'pull_request' }}

samhh avatar May 05 '22 22:05 samhh