github-actions-dhall icon indicating copy to clipboard operation
github-actions-dhall copied to clipboard

Strategy matrix doesn't support excluding some combinations

Open erwan opened this issue 3 years ago • 2 comments

Currently, Strategy::matrix is defined as a List { mapKey : Text, mapValue : List Text }:

https://github.com/regadas/github-actions-dhall/blob/master/types/Strategy.dhall

However, Github Actions supports having an exclude key that is a list of records (not Text):

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-excluding-configurations-from-a-matrix

Currently it's not possible to specify an exclude field in the matrix, because it doesn't match the type.

erwan avatar May 11 '21 12:05 erwan

Hi @erwan! Thanks for the report!

Do you feel you can find some time to propose a fix? 😄 🙏

regadas avatar Jun 26 '21 16:06 regadas

Actually I tried, but I don't know how to fix it! I couldn't find a way to type the exclude field.

It's too generic, we would want a list of objects that can have any key. I couldn't find how to do that in dhall...

erwan avatar Jun 26 '21 19:06 erwan