storycap icon indicating copy to clipboard operation
storycap copied to clipboard

bug?: `viewports` overrides local `viewport` parameter

Open lacolaco opened this issue 4 years ago • 2 comments

Component-local viewport parameter seems being overridden by global viewports parameter.

Use-case

I want to take screenshots with some common viewports and some stories have its own proper viewport specifically. I expected component-local or story-local parameters can override global one from preview.ts, but it didn't work as I imagined.

// preview.ts
export const paramters = {
  screenshot: {
    viewports: {
      small: { width: 599, height: 400 },
      large: { width: 960, height: 400 },
    },
  },
};
// comp.stories.ts

export default {
  ...,
  parameters: {
    screenshot: { viewport: { width: 960, height: 640 } },
  },
} as Meta;
  • Is this by design? or unexpected bug?
  • Any alternatives?

lacolaco avatar Sep 27 '21 06:09 lacolaco

{ viewports: [], viewport: { width: 960, height: 640 } } can override global viewports.

lacolaco avatar Sep 27 '21 06:09 lacolaco

I think its because you are not overriding the same key. In global you set viewports but locally you set viewport. I guess viewports has precedence over viewport

sag1v avatar Jun 13 '22 11:06 sag1v