Suspected issue with squashing pull requests

[ardaerzin]

Describe the bug

We've just recently implemented reg-suit, but noticed an unexpected behavior after creating our first pull requests after merging visual regression tests to master.

all of our PRs come with all new test results, as it fails to find the actual shots. did follow your instructions exactly, no changes. did try the other simple key plugin, again no success. then it occurred to me that, we squash our commits when merging, which means the previous commit she's are getting lost in the process.

Expected behavior

cannot find previous actual screenshots

Actual behavior

has to be able to find previous shots, which were taken in the most recent merge (squashed)

[mstllc]

I am just reviewing reg-suit for our needs and it looked promising until I found this issue. @ardaerzin there are no other comments here, did you ever get any updates on this or what did you end up doing? We definitely use squash when mergin as well and aren't going to change that, so maybe a deal breaker...

[ardaerzin]

@mstllc hey sorry I just saw this (also saw how the initial message was butchered by iOS autocorrect).

we are using reg-simple-keygen-plugin instead of reg-keygen-git-hash-plugin

we keep folder named master in s3, which is referenced against on all of our PRs, and use pr-names to keep track of differences

[janickvwcotiss]

Does anyone have any updates on this? I am in a same boat, every time we open a PR against main, all the components come up as new (see picture). However, PRs into feature branches seem to work fine.