reg-cli icon indicating copy to clipboard operation
reg-cli copied to clipboard

Search input does not filter the results

Open ghost opened this issue 3 years ago • 3 comments

Describe the bug

Search input does not filter the results

Reproduced step

Steps to reproduce the behavior:

  1. npm i -g reg-cli
  2. reg-cli visreg/reference visreg/test rvisreg/diff -R ./visreg/report.html
  3. open report
  4. filter name with '05_'
  5. everything is still shown

Expected behavior

I'm expecting one or more images to disappear when filtering.

Actual behavior

Filtering shows all screenshots regardless of the name (might be related to this https://github.com/reg-viz/reg-cli-report-ui/issues/28) ?

Screenshots

Peek 2021-05-04 15-46

ghost avatar May 04 '21 13:05 ghost

Without -X option, reg-cli don't create worker script for reg-cli-report-ui. However, in reg-cli-report-ui, filtering action is in worker script :(

I suggest reg-cli create worker script, regardless of whether use -X or not.

sam8helloworld avatar Oct 17 '21 00:10 sam8helloworld

sorry for late.I'll do some investigation later.

bokuweb avatar Oct 17 '21 01:10 bokuweb

Hi @sam8helloworld , what script is it supposed to create when using option -X? Is it just a javascript file or do I need nodejs to run the html report with search functionality? I tried generating the report with the -X option, but search is still not working for me.

ghost avatar Oct 18 '21 08:10 ghost