reframe icon indicating copy to clipboard operation
reframe copied to clipboard

[feat] Add the Firecrest slurm scheduler

Open ekouts opened this issue 1 year ago • 2 comments

Includes also changes from #3054, as soon it is merged the diff will be a bit smaller.

In order to test it these variables need to be set:

export RFM_USE_LOGIN_SHELL=true
export RFM_RESOLVE_MODULE_CONFLICTS=false

export FIRECREST_CLIENT_ID=<client-id>
export FIRECREST_CLIENT_SECRET=<client-secret>
export FIRECREST_URL=<firecrest-url>
export AUTH_TOKEN_URL=<auth-token-url>
export FIRECREST_SYSTEM=daint # This is the name of the system for firecrest
export FIRECREST_BASEDIR='/scratch/snx3000/<user>/rfc_remote'

reframe --system=daint ...

ekouts avatar Nov 16 '23 08:11 ekouts

Hello @ekouts, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2024-01-09 08:56:44 UTC

pep8speaks avatar Nov 16 '23 08:11 pep8speaks

Codecov Report

Attention: 171 lines in your changes are missing coverage. Please review.

Comparison is base (5ca9de6) 86.61% compared to head (5c2278c) 85.43%. Report is 23 commits behind head on develop.

:exclamation: Current head 5c2278c differs from pull request most recent head b7f44fd. Consider uploading reports for the commit b7f44fd to get more accurate results

Files Patch % Lines
reframe/core/schedulers/slurm.py 11.85% 171 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3046      +/-   ##
===========================================
- Coverage    86.61%   85.43%   -1.18%     
===========================================
  Files           61       61              
  Lines        12035    12230     +195     
===========================================
+ Hits         10424    10449      +25     
- Misses        1611     1781     +170     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 21 '23 10:11 codecov[bot]