reframe icon indicating copy to clipboard operation
reframe copied to clipboard

add support for combining partitions and features in valid_systems

Open smoors opened this issue 2 years ago • 1 comments

currently, combining sysname:partname with features is not fully supported in ReFrame (tested in v4.0.5)

for example, this works (multiple list items behave like the OR operation):

valid_partitions = ['*:ampere', '+cpu']

but this does not (multiple string words behave like AND operation):

valid_partitions = ['*:ampere +cpu']

this is what ReFrame shows in the latter case:

WARNING: skipping test 'GROMACS_EESSI': type error: test-suite/eessi/reframe/eessi-checks/applications/gromacs_check.py:62: failed to set field 'valid_systems': '['*:ampere +gpu']' is not of type 'List[Str[r'^(((\*|(\w[-.\w]*))(:(\*|(\w[-.\w]*)))?)|(([+-](\w[-.\w]*))|(%(\w[-.\w]*)=\S+))(\s+(([+-](\w[-.\w]*))|(%(\w[-.\w]*)=\S+)))*)$']]'
                self.valid_systems = [valid_systems]

would it be possible to implement this?

smoors avatar Mar 10 '23 17:03 smoors

That's a case we haven't thought about and that's why it doesn't validate. We need to have a closer look to check what supporting this implies.

vkarak avatar Mar 10 '23 21:03 vkarak