reflex-platform icon indicating copy to clipboard operation
reflex-platform copied to clipboard

Test script is broken

Open alexfmpe opened this issue 4 years ago • 3 comments

$ ./scripts/test
If you have any trouble with this script, please submit an issue at https://github.com/reflex-frp/reflex-platform/issues
#1-NixOS SMP Sun Jul 14 06:09:53 UTC 2019
Please enable reflex's binary cache by following the instructions at https://github.com/reflex-frp/reflex-platform/blob/develop/notes/NixOS.md

/home/alexfmpe/repos/reflex-platform/scripts/test.hs:96:15: error:
    • No instance for (Control.Monad.Fail.MonadFail Sh)
        arising from a do statement
        with the failable pattern ‘True’
    • In a stmt of a 'do' block:
        True <- (liftM (const False)
                   $ run (s </> ("hack-on" :: String)) [fromString repo])
                  `catchany_sh` (\ _ -> return True)
      In the expression:
        do let fileToChange = repo </> (filename :: String)
               contents = "test"
           writefile fileToChange contents
           True <- (liftM (const False)
                      $ run (s </> ("hack-on" :: String)) [fromString repo])
                     `catchany_sh` (\ _ -> return True)
           newContents <- readfile fileToChange
           ....
      In the second argument of ‘($)’, namely
        ‘\ s tmp
           -> do let ...
                 writefile fileToChange contents
                 ....’
   |
96 |               True <- (liftM (const False) $ run (s </> ("hack-on" :: String)) [fromString repo]) `catchany_sh` (\_ -> return True)
   |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/home/alexfmpe/repos/reflex-platform/scripts/test.hs:108:11: error:
    • No instance for (Control.Monad.Fail.MonadFail Sh)
        arising from a do statement
        with the failable pattern ‘True’
    • In a stmt of a 'do' block:
        True <- test_d $ tmp </> repo </> (".git" :: String)
      In the expression:
        do run (d </> ("hack-on" :: String)) [fromString repo]
           False <- or
                      <$>
                        sequence
                          [test_e $ tmp </> repo </> ("git.json" :: String),
                           test_e $ tmp </> repo </> ("github.json" :: String)]
           True <- test_d $ tmp </> repo </> (".git" :: String)
           return ()
      In the second argument of ‘($)’, namely
        ‘\ d tmp
           -> do run (d </> ("hack-on" :: String)) [...]
                 False <- or <$> sequence [...]
                 ....’
    |
108 |           True <- test_d $ tmp </> repo </> (".git" :: String)

alexfmpe avatar Oct 11 '19 00:10 alexfmpe

Need to use shelly 1.9.0 for this instance

alexfmpe avatar Oct 11 '19 00:10 alexfmpe

Hah, I just bumped shelly in a branch of obelisk too. We should probably just do it up here.

3noch avatar Jan 04 '20 06:01 3noch

Thanks for pointing that out @alexfmpe.

3noch avatar Jan 04 '20 06:01 3noch

Test script is still broken. Seems like literate haskell didn't like https://github.com/reflex-frp/reflex-platform/commit/bd9835d64cdd2808acdb8d772f208821c70476dd and there's also some other errors down the line on the benchmark stuff, Don't think this should be marked as completed, unless there's plans to get rid of failing tests?

alexfmpe avatar Dec 19 '23 12:12 alexfmpe