Location.manageHistory: Consider dispatching the event for changes to route

[3noch]

manageHistory currently maintains changes to the route internally but any other JS code listening for route events won't be notified when these updates happen. We can dispatch this event and rely on the browser to update the Dynamic for us. There are a few choices to consider, however, namely if we want the event to bubble, etc.

dispatchEvent' :: Dom.Window -> JSM ()
dispatchEvent' window = do
  obj@(JS.Object o) <- JS.create
  JS.objSetPropertyByName obj (t_ "cancelable") True
  JS.objSetPropertyByName obj (t_ "bubbles")    True
  JS.objSetPropertyByName obj (t_ "view")       window
  event <- newPopStateEvent (t_ "popstate") $ Just $ pFromJSVal o
  dispatchEvent_ window event

browserHistoryWith only provides half of the story that manageHistory offers. However, if the browser were handling the updates for us, we could write manageHistory in terms of browserHistoryWith.

[ryantrinkle]

This is an interesting idea, but I'm not sure exactly when it should be done or what other ramifications it might have. Do JS libraries usually do this - i.e. is there an established best-practice?

Separately, shouldn't something like this be used to construct the event?

[3noch]

That code is actually from reflex-dom-contrib. You're right that it can likely be modernized.

Good question about best practices. It could even be that we should add this to HistoryCommand so that the user can decide.