reflex icon indicating copy to clipboard operation
reflex copied to clipboard

remix over next

Open adhami3310 opened this issue 11 months ago β€’ 4 comments

almost, usable, but needs to port 404, figure out titles and such, make sure events aren't broken, and bring back sitemap, among other things

adhami3310 avatar Mar 18 '25 06:03 adhami3310

CodSpeed Performance Report

Merging #4984 will degrade performances by 6.67%

Comparing remix-over-next (b795f12) with main (7f88d9d)

Summary

⚑ 2 improvements
❌ 1 regressions
βœ… 5 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚑ test_get_all_imports[_complicated_page] 28.8 ms 26.6 ms +8.06%
⚑ test_get_all_imports[_stateful_page] 3.9 ms 3.7 ms +3.96%
❌ test_evaluate_page[_complicated_page] 45.9 ms 49.1 ms -6.67%

codspeed-hq[bot] avatar Mar 18 '25 06:03 codspeed-hq[bot]

:)

Alek99 avatar Mar 19 '25 05:03 Alek99

internal nav without breaking websocket support dynamic routes (and hopefully translate existing syntax)

i was a bit stuck on these two, the code for them was very tied to nextjs way of doing things, so help there is appreciated

pre-render HTML and use hydrateRoot

we do have an SSR option but i don't know how much it does

there are also other things:

  • [x] titles/meta tags aren't working quite the same in nextjs
  • [x] sitemap needs to be restored (#4923 should handle this)
  • [x] dynamic rendering needs to be moved off of nextjs syntax

adhami3310 avatar Mar 20 '25 07:03 adhami3310

JSX syntax to JS syntax trnasformation seems to be done (we can in theory make that its own PR)

adhami3310 avatar Mar 20 '25 17:03 adhami3310

Here's the current checklist:

  • [x] implement sitemap functionality
  • [ ] fix the two integration tests for event actions and event chains
  • [x] verify things like dynamic routes are largely working (we currently only support [arg], not the other things like catchall)

adhami3310 avatar May 24 '25 01:05 adhami3310

and it probably shares too much information

isn't that already happening? state.js imports it so it has to get it (in dev and prod, but in prod it prob gets a tad but more bundled)

adhami3310 avatar Jun 11 '25 17:06 adhami3310

reflex-chakra no longer working

  File "/Users/masenf/code/reflex-dev/reflex/.venv/lib/python3.13/site-packages/reflex_chakra/components/navigation/breadcrumb.py", line 4, in <module>
    from reflex_chakra.components.navigation.link import Link
  File "/Users/masenf/code/reflex-dev/reflex/.venv/lib/python3.13/site-packages/reflex_chakra/components/navigation/link.py", line 5, in <module>
    from reflex.components.next.link import NextLink
ModuleNotFoundError: No module named 'reflex.components.next.link'

masenf avatar Jun 13 '25 17:06 masenf