reflex
reflex copied to clipboard
reflex-dev
Feature: Added Dockerfile to Create Docker Image Of Pynecone
This PR involves:
- Adding a Dockerfile
- Building Docker Image For Pynecone
To Run The Container Locally Do The Following:
- Install Docker On Your Local Machine
- Clone the pynecone repository by running the command:
git clone https://github.com/pynecone-io/pynecone.git - RUN:
docker build -t pynecone .inside the Dockerfile Directory of the terminal - Then RUN:
docker run -it -d -p 3000:3000 pynecone_image - After that you can see the Demo Webpage on
http://localhost:3000OR we can view the content by typing the following command in the terminal :curl http://localhost:3000
I would like to give the suggestion of pushing the Docker Image to DockerHub
What do you think of the idea of building a multistage image? This would dramatically reduce the size of the container image.
I would recommend to create a docerfile sample with which every Pynecone developer can build an optimised container image himself. To my eye, this Dockerfile produces an image that only produces a sample app and cannot be used for other projects. For this reason, I would not recommend pushing the resulting image to Docker Hub or any other public registry.
In my option, we should combine RUN lines to single command, this result less layers and snaller image size.
I have open another PR #387 with all the changes. There were too many changes that I should have described here.
The PR looks awesome @r0b2g1t !
If possible, I would love to get some feedback on how I can improve my skills and what I could have done better.😃
Thank You!
The PR looks awesome @r0b2g1t !
If possible, I would love to get some feedback on how I can improve my skills and what I could have done better.😃
Thank You!
Thanks for working on that last PR @SaarthakMaini we really appreciate It. Many more issues we'll need help on to come and can definitely use your help. Sorry we were not able to merge in your pr we just accepted the other pr because it was finished and we were trying to get the release out by today.
We can sync on discord soon and decide more things to work on for the next release if you have time. Really appreciate your help and attention to detail its great to have contributors like you!🙂
