reflex icon indicating copy to clipboard operation
reflex copied to clipboard

Mirgrate from pip to uv

Open ericwb opened this issue 1 year ago β€’ 2 comments

In order to improve build time performance, this change switches usage of pip to uv. The uv command is a pip alternative promising much faster installs of Python packages.

For more information on uv, see: https://github.com/astral-sh/uv

Closes #2748

All Submissions:

  • [x] Have you followed the guidelines stated in CONTRIBUTING.md file?
  • [x] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)

New Feature Submission:

  • [x] Does your submission pass the tests?
  • [x] Have you linted your code locally prior to submission?

Changes To Core Features:

  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

ericwb avatar May 13 '24 17:05 ericwb

I've compared the execution time to other PRs that don't use uv yet, but I don't find any significant improvement on the runtime of jobs.

However, I think we can still go ahead with this PR anyway.

Lendemor avatar May 14 '24 08:05 Lendemor

I've compared the execution time to other PRs that don't use uv yet, but I don't find any significant improvement on the runtime of jobs.

However, I think we can still go ahead with this PR anyway.

Yeah, I didn't see much of a performance boost. I suspect its probably because poetry is installing most of the dependencies.

ericwb avatar May 14 '24 16:05 ericwb