reflex icon indicating copy to clipboard operation
reflex copied to clipboard

[REF-2824] rx.recharts.polar_radius_axis is missing the `domain` prop

Open masenf opened this issue 1 year ago β€’ 2 comments

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  • Code/Link to Repo:

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Specifics (please complete the following information):

  • Python Version:
  • Reflex Version:
  • OS:
  • Browser (Optional):

Additional context Add any other context about the problem here.

REF-2824

masenf avatar May 13 '24 17:05 masenf

Hi @masenf I checked the link above that leads to the Discord channel. By my understanding, you've provided the solution of this issue there. The only thing missing to get this resolved is a PR. So I just need to add the following line custom_attrs=dict(domain=rx.Var.create([0, 250])) to the file reflex./components/recharts/polar.py in the component PolarRadiusAxis(Recharts):

TG199 avatar May 20 '24 14:05 TG199

@TG199 All that's needed here is a PR that adds domain as a list[int] prop to the PolarRadiusAxis component.

The custom_attrs thing is a hackaround for forcing an attribute to be rendered into the compiled output, even when it's not declared as a prop for the component.

masenf avatar May 20 '24 18:05 masenf

Merged in #3349

picklelo avatar Jun 05 '24 17:06 picklelo