reflex icon indicating copy to clipboard operation
reflex copied to clipboard

Lru caching

Open AmanSal1 opened this issue 1 year ago β€’ 3 comments

All Submissions:

  • [ ] Have you followed the guidelines stated in CONTRIBUTING.md file?
  • [ ] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

New Feature Submission:

  • [ ] Does your submission pass the tests?
  • [ ] Have you linted your code locally prior to submission?

Changes To Core Features:

  • [X] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [X] Have you written new tests for your core changes, as applicable?
  • [ ] Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR. 
Addition of LRU Caching 

b. Describe your changes.
 LRU Caching using third party libraries and adding the associated test case for it .

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).
Fixes: 

#3021

AmanSal1 avatar Apr 17 '24 17:04 AmanSal1

@ElijahAhianyo I accidently committed in the same branch . I have changed only state.py and test_state.py .

AmanSal1 avatar Apr 17 '24 17:04 AmanSal1

This PR is removing upload.py when it shouldn't.

We won't be able to merge it until the changes to upload.py are removed from the PR.

Lendemor avatar Apr 22 '24 11:04 Lendemor

@Lendemor Just a demo PR, need not be merged

AmanSal1 avatar Apr 22 '24 11:04 AmanSal1