reflex
reflex copied to clipboard
reflex-dev
Default styling for rx.upload
All Submissions:
- [X] Have you followed the guidelines stated in CONTRIBUTING.md file?
- [X] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?
Type of change
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
New Feature Submission:
- [ ] Does your submission pass the tests?
- [X] Have you linted your code locally prior to submission?
Changes To Core Features:
- [X] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you written new tests for your core changes, as applicable?
- [ ] Have you successfully ran tests with your changes locally?
After these steps, you're ready to open a pull request.
a. Give a descriptive title to your PR.
Adding a default styling to the rx.upload method
b. Describe your changes.
I have implemented a logic to provide default styling. Whenever a user employs rx.upload, default styling will be applied if
not explicitly mentioned. Users can override these defaults with custom styles if desired.
c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).
Fixes : #2967
@picklelo I have implemented logic to apply default styling, and I would like you to review it. I have verified that users can directly override the existing default styles. However, I haven't written any test cases yet. Once you confirm, we can proceed to add the necessary test cases .
