reflex icon indicating copy to clipboard operation
reflex copied to clipboard

Refactored project dependencies

Open palashcode opened this issue 2 years ago β€’ 2 comments

All Submissions:

  • [x] Have you followed the guidelines stated in CONTRIBUTING.md file?
  • [x] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

New Feature Submission:

  • [x] Does your submission pass the tests?
  • [ ] Have you linted your code locally prior to submission?

Refactored project dependencies: Moved 'plotly' and 'redis' dependencies from regular dependencies to dev dependencies using Poetry. This change ensures that these dependencies are only required for development purposes, reducing the overall project dependencies. closes #1240

palashcode avatar Jun 26 '23 13:06 palashcode

i think using extras is better here than better dev dependencies... because redis and plotly are needed to deploy production apps that use these libraries, and they wouldn't want all of the other dev dependencies.

https://python-poetry.org/docs/pyproject/#extras

masenf avatar Jun 28 '23 19:06 masenf

Hi @masenf and @picklelo, I created a fresh PR here(https://github.com/pynecone-io/pynecone/pull/1295) for this making the changes suggested by you. Can you please review it and suggest improvements.

Made following changes

  • Made plotly and redis optional and extra dependecies.
  • Added try/except in the code where plotly and redis are used to throw error and prompt user to install these extra dependencies.
  • Did a rebase on to the main branch.

palashcode avatar Jul 01 '23 17:07 palashcode

Closing in favor of #1816, which will address the plotly side of things and start moving us in this direction.

masenf avatar Sep 14 '23 22:09 masenf