refine icon indicating copy to clipboard operation
refine copied to clipboard

chore(antd): update `@ant-design/icons` and `@ant-design/pro-layout` dependencies

Open aliemir opened this issue 1 year ago • 5 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

  • [x] Related issue(s) linked
  • [x] Tests for the changes have been added
  • [x] Docs have been added / updated
  • [x] Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

Changes

After @ant-design/icons version 5.4.0 build issues and type issues are resolved. Following this release @ant-design/pro-layout also updated its dependency range to match the latest @ant-design/icons version.

Previously @ant-design/icons were pinned to 5.0.1 and recommended to pin in projects as well. After this update, you may also need to update the @ant-design/icons version in your project to match the latest version. (A range above ^5.5.1 is required to match @refinedev/antd).

resolves #6363 resolves #5931 - previously resolved by #5934 Accompanies #6354 - @ant-design/pro-layout also depends on express dependency and updated its version in the latest release

aliemir avatar Sep 24 '24 12:09 aliemir

🦋 Changeset detected

Latest commit: f951cbfbf5a9a26e1c0d2c1b4684d521a70feb5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@refinedev/antd Minor
@refinedev/inferencer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 24 '24 12:09 changeset-bot[bot]

🚀 Deployed on https://deploy-preview-finefoods-antd-6369-merge--refine-doc-preview.netlify.app

github-actions[bot] avatar Sep 24 '24 12:09 github-actions[bot]

refine    Run #11608

Run Properties:  status check passed Passed #11608  •  git commit def1765d54 ℹ️: Merge fec8a695aaf0ce94af00ec240d7d1c80ca0a8cab into 61c809037235e85c3d79497b68ea...
Project refine
Branch Review chore/ant-design-dependency-bump
Run status status check passed Passed #11608
Run duration 16m 49s
Commit git commit def1765d54 ℹ️: Merge fec8a695aaf0ce94af00ec240d7d1c80ca0a8cab into 61c809037235e85c3d79497b68ea...
Committer Ali Emir Şen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 26
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 171
View all changes introduced in this branch ↗︎

cypress[bot] avatar Sep 24 '24 13:09 cypress[bot]

I was about to create a similar PR to bump pro-layout, glad to see this is already worked on. We are getting install/build warnings due to this: image

Hopefully it can be merged soon.

bombillazo avatar Sep 29 '24 05:09 bombillazo

Hey @bombillazo, due to the issues with lodash and lodash-es in the latest version of @ant-design/pro-layout we're waiting for a fix to be released. I've opened up a PR https://github.com/ant-design/pro-components/pull/8754. As soon as this is merged and released, we'll include this PR to our release 🙏

aliemir avatar Oct 07 '24 12:10 aliemir