refine
refine copied to clipboard
fix(rtl-customisation): changed the header back button orientations o…
…f all the components and sidebar collapse button from left to right
PR Checklist
Please check if your PR fulfills the following requirements:
- [x] The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention
Bugs / Features
- [x] Related issue(s) linked
- [x] Tests for the changes have been added - There were no tests for the example that I made changes to
- [ ] Docs have been added / updated
- [ ] Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset
What is the current behavior?
In the current behaviour whenever we use the rtl-customisation example the arrows are not aligned from right to left
What is the new behavior?
The arrows are not aligned to the right to left format
fixes # (issue) https://github.com/refinedev/refine/issues/5953#issuecomment-2119900397
Notes for reviewers
If anyone could help me with the documentation and changesheet part, I have never done that and I followed the documentation but I have some doubts
⚠️ No Changeset found
Latest commit: 156f0612cb169a9edbea1c3788184559a0f26e4d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Got it @aliemir I'll make the necessary changes and get back to you.
@aliemir Thanks for the help, I had no idea about the antd ConfigProvider, could you please take a look at this PR, and let me know if anything needs to be changed!!
@aliemir sure I can work on the tests as well, Do I do this in this PR only or do I need to raise a different one? I'll surely ask you if I get stuck somewhere, do let me know how do I reach out to you!!
Hey @ApsMJ23 you can do it in this PR.
@aliemir This looks good to me, It was a great learning experience I learned more by contributing on this than my day job xD, Please lemme know if I can do anything more to make refine better!!