refine icon indicating copy to clipboard operation
refine copied to clipboard

fix(antd): pin `ant-design/icons` dependency version

Open bombillazo opened this issue 1 year ago • 9 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

  • [ ] Related issue(s) linked
  • [ ] Tests for the changes have been added
  • [ ] Docs have been added / updated
  • [ ] Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

What is the current behavior?

Re-add locking of "@ant-design/icons" to known working behavior

What is the new behavior?

Bypasses issue #5931

Notes for reviewers

bombillazo avatar May 08 '24 17:05 bombillazo

🦋 Changeset detected

Latest commit: 758c80adab2d8c9cfc348278d9cd26811da8f4a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@refinedev/inferencer Patch
@refinedev/antd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 08 '24 17:05 changeset-bot[bot]

Deploy Preview for refine-video-club failed.

Name Link
Latest commit c74e5d3298be7d89fb2d808a138e6b84ff31567b
Latest deploy log https://app.netlify.com/sites/refine-video-club/deploys/6647ca6b91a3380008c99b4f

netlify[bot] avatar May 08 '24 17:05 netlify[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fa74d6c9d21fb403160db9c940072f8081bff40b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar May 09 '24 06:05 nx-cloud[bot]

Hey @bombillazo can you do the changes for every occurence of this package? Also don't forget to do pnpm install after the changes, so pnpm-lock.yaml will also be updated. Also make sure to create patch changeset for affected packages.

BatuhanW avatar May 23 '24 07:05 BatuhanW

Deploy request for refine-crm rejected.

Name Link
Latest commit 0ce365bc7c36356dd835bb8ac0b5f0d1f0d644eb

netlify[bot] avatar May 23 '24 13:05 netlify[bot]

image

This error pops up after trying to update the branch

bombillazo avatar May 23 '24 14:05 bombillazo

Passing run #11126 ↗︎

0 379 37 0 Flakiness 0

Details:

refactor(store): update store homepage and checkout design (#5960)
Project: refine Commit: d0ace600ba
Status: Passed Duration: 21:40 💡
Started: May 24, 2024 6:13 AM Ended: May 24, 2024 6:34 AM

Review all test suite changes for PR #5934 ↗︎

cypress[bot] avatar May 24 '24 06:05 cypress[bot]

image

This error pops up after trying to update the branch

Hey @bombillazo, this is probably thrown because there are mismatching dependencies in examples etc. for @ant-design/icons. Can you try fixing the version for all occurrences and see if the issue persists? 🙏

aliemir avatar May 24 '24 11:05 aliemir

OK now its updated

bombillazo avatar May 24 '24 11:05 bombillazo